Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip attribute to serialization proc macros #903

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

Lorak-mmk
Copy link
Collaborator

@Lorak-mmk Lorak-mmk commented Jan 4, 2024

As requested in #899, this PR adds a field attribute to SerializeCql and SerializeRow macros that allow to skip given field during serialization.
This can be useful for fields unrelated to database.

Fixes: #899

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@Lorak-mmk Lorak-mmk force-pushed the serialize_skip_field branch from 34af579 to 2796feb Compare January 4, 2024 14:37
@Lorak-mmk Lorak-mmk requested a review from piodul January 4, 2024 14:37
@Lorak-mmk Lorak-mmk force-pushed the serialize_skip_field branch from 2796feb to 5a0b285 Compare January 4, 2024 14:55
@piodul piodul merged commit befa148 into scylladb:main Jan 4, 2024
8 checks passed
@avelanarius avelanarius added this to the 0.12.0 milestone Jan 15, 2024
@Lorak-mmk Lorak-mmk mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore field feature
3 participants