Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update batch.md to warn about automatic preparation #886

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

piodul
Copy link
Collaborator

@piodul piodul commented Dec 18, 2023

Add warnings about the fact that Session::batch now automatically prepares simple statements with non-empty value lists. Update the first example not to use such statements in order not to promote suboptimal usage of the API.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Add warnings about the fact that Session::batch now automatically
prepares simple statements with non-empty value lists. Update the first
example not to use such statements in order not to promote suboptimal
usage of the API.
@piodul piodul requested a review from Lorak-mmk December 18, 2023 03:18
@Lorak-mmk Lorak-mmk merged commit 0edaaca into scylladb:main Dec 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants