Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codewide: re-structure modules (v2) #817

Closed
wants to merge 43 commits into from

Conversation

Lorak-mmk
Copy link
Collaborator

@Lorak-mmk Lorak-mmk commented Sep 26, 2023

This is #804 with clippy errors fixed and rebased on main.
Original message:

According to the new proposed design, the structure of modules and imports is changed to provide more rational code separation.

* `scylla-cql` is no longer exposed; only some entities are selectively re-exported using new `cql` module;

* `transport` module is decomposed and a number of new modules emerge instead.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • [ ] I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • [ ] I added appropriate Fixes: annotations to PR description.

@Lorak-mmk Lorak-mmk requested review from piodul, cvybhu and havaker and removed request for piodul September 26, 2023 11:10
@Lorak-mmk Lorak-mmk mentioned this pull request Sep 26, 2023
5 tasks
@Lorak-mmk
Copy link
Collaborator Author

@wprzytula I'm closing this because I understand that you will make a new version of those changes with cleaned up commits.

@Lorak-mmk Lorak-mmk closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants