result: add "Custom" metadata type #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CQL protocol allows sending custom types identified by their string representation. One of the cases in which the trick is used is when Cassandra returns duration columns to a CQLv4 client, which is not supposed to know this type. WIP: the actual implementation will be done once #363 is merged. Refs #364
psarna
force-pushed
the
custom_cql_types
branch
from
4398cd3 to
ad8b0c1
Compare
piodul
reviewed
Mar 17, 2022
There was a problem hiding this comment.
Looks good, although IMO the title add support for custom CQL type suggests too much - as if this commit allows to read and write values of custom type. Meanwhile, it only parses the "custom" type from result metadata and reading/writing custom type values is still not supported.
Please change the description to better reflect the actual change. Moreover, if you intended to remove the WIP line from the PR description, then please remove it from the commit description, too.
psarna
changed the title
|
thx, done |
|
It looks like the commit still has the wrong description :( |
|
Committed in 2cf503b. Fixed the commit message manually before pushing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CQL protocol allows sending custom types identified by their
string representation. One of the cases in which the trick is used
is when Cassandra returns duration columns to a CQLv4 client, which
is not supposed to know this type.
Refs #364
Pre-review checklist
Fixes:annotations to PR description.