Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macros: generate automatically_derived attribute #1145

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

wprzytula
Copy link
Collaborator

It is customary that auto-generated trait impls have that attribute. Also, this disables dead code analysis for derived impls.

Fixes: #1140

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • [ ] I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have provided docstrings for the public items that I want to introduce.
  • [ ] I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

It is customary that auto-generated trait impls have that attribute.
Also, this disables dead code analysis for derived impls.
@wprzytula wprzytula self-assigned this Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 69f6e59

@wprzytula wprzytula added this to the 0.15.1 milestone Dec 8, 2024
@wprzytula wprzytula merged commit 7710af0 into scylladb:main Dec 8, 2024
11 checks passed
@wprzytula wprzytula deleted the add-automatically-derived branch December 8, 2024 11:20
wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this pull request Dec 11, 2024
…ived

macros: generate automatically_derived attribute
(cherry picked from commit 7710af0)
@wprzytula wprzytula mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add #[automatically_derived] attribute to impls generated by ser/de proc macros
2 participants