rows_result: implement into_inner behind cpp_rust_unstable cfg
#1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Lorak-mmk
requested changes
Nov 29, 2024
muzarski
force-pushed
the
cpp-rust-decouple-query-rows-result
branch
from
618657c to
33a5455
Compare
|
v2: Changed |
Lorak-mmk
approved these changes
Nov 29, 2024
This is convenience introduced only for cpp-rust-driver purposes. We will use DeserializedMetadataAndRawRows directly to implement lazy deserialization in cpp-rust-driver
muzarski
force-pushed
the
cpp-rust-decouple-query-rows-result
branch
from
33a5455 to
ead6ef0
Compare
muzarski
changed the title
cpp_rust_unstable cfg
|
v2.1: rebased on main (CI fixes) and adjusted PR title |
wprzytula
approved these changes
Dec 2, 2024
Lorak-mmk
approved these changes
Dec 2, 2024
wprzytula
pushed a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Dec 11, 2024
…y-rows-result rows_result: implement into_inner behind `cpp_rust_unstable` cfg (cherry picked from commit 62f96b3)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is convenience introduced only for cpp-rust-driver purposes.
We will use DeserializedMetadataAndRawRows directly to implement lazy deserialization in cpp-rust-driver
Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.