-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump msrv to 1.70 #1098
Bump msrv to 1.70 #1098
Conversation
It enables sparse cargo index by default, which in turn will make performing MSRV checks locally less of a pain.
- Make it clear where the MSRV changes will be published. - Allow MSRV bumps after 1.0.
This is a field that describes current MSRV of the crate. In the future it will be used by Cargo during resolving to get versions compatible with users toolchain. For that reason we should provide it.
|
Then we will not support versions that were released more than 6 months ago. You probably meant that MSRV should be a version that is at least 6 months old (AFAIU, this is the tokio's policy), correct? If so, then I agree that such policy makes sense. |
Yes, you're right, and that is what I'd like to propose. And just like Tokio, this wouldn't be automatic: if we don't see the benefit in bumping MSRV we can stay on older one for much longer. |
@muzarski I updated the description regarding the 6 months policy. |
Checking MSRV locally is frustrating, because it requires switching toolchain and renaming files, but it is even more frustrating because updating cargo index before 1.70 is so sloooooow.
1.70 switched to sparse cargo index protocol by default, which makes checking the crate much faster. Let's bump MSRV to improve developer experience.
I also added "rust-version" field to Cargo.toml files, because this is the official place to specify MSRV and in the future will be used by Cargo during dependency resolving.
1.70 is over a year old (released on 1st June 2023), so I doubt this bump will cause any problems.
Related: we will need to decide on MSRV policy past 1.0. I propose to settle on 6 month policy (= our MSRV must always be at least 6 months old).
Rust ecosystem seems to not be very conservative on this:
Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.