examples: replace query_unpaged for SELECT queries
#1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
muzarski
force-pushed
the
replace-query-unpaged-in-examples
branch
from
f940879 to
5e78c02
Compare
muzarski
force-pushed
the
replace-query-unpaged-in-examples
branch
from
5e78c02 to
74fcecf
Compare
Replaced query_unpaged usages for SELECTs with query_iter in cql-time-types.rs example.
There were a lot of unwraps in this example, which are not encouraged and introduce some noise. Let's return a Result from main and propagate the errors.
muzarski
force-pushed
the
replace-query-unpaged-in-examples
branch
from
74fcecf to
18bdbd1
Compare
Lorak-mmk
approved these changes
Aug 28, 2024
wprzytula
approved these changes
Aug 29, 2024
Comment on lines
-10
to
-12
| let session: Session = SessionBuilder::new().known_node(uri).build().await.unwrap(); | ||
| let session: Session = SessionBuilder::new().known_node(uri).build().await?; | ||
|
|
||
| session.query_unpaged("CREATE KEYSPACE IF NOT EXISTS examples_ks WITH REPLICATION = {'class' : 'NetworkTopologyStrategy', 'replication_factor' : 1}", &[]).await.unwrap(); |
There was a problem hiding this comment.
Wow, the fact that unwraps were here surprised me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1068
In this PR we replace
query_unpagedoccurrences for SELECTs with eitherquery_iter.Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.