result: fix bug: paging state taken from PREPARED response instead of RESULT #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug is fixed that when `set_use_cached_result_metadata` flag is set, then the ResultMetadata would be taken from PreparedStatement including paging_state, effectively yielding empty paging state for every request with the flag set. A regression test is added.
wprzytula
force-pushed
the
fix-cached-metadata
branch
from
708ae23 to
5249309
Compare
|
|
Lorak-mmk
approved these changes
Aug 22, 2024
wprzytula
added a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Aug 22, 2024
result: fix bug: paging state taken from PREPARED response instead of RESULT (cherry picked from commit 45f0288)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug is fixed that when
set_use_cached_result_metadataflag is set, then theResultMetadatawould be taken fromPreparedStatementincludingpaging_state, effectively yielding empty paging state for every request with the flag set.A related regression test is added.
Pre-review checklist
[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.