Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new deserialization API #1057
Introduce new deserialization API #1057
Changes from 1 commit
51c1005
e67e5da
463b9b5
ed57255
8e36957
6daf833
c1416dd
e9d4719
37ff7c6
c229ae5
22f28cd
2ec2885
b3f4a04
001b5bb
db6bee0
6d9d971
f3aae01
2b5f386
5919cf9
9a092f9
a204a7b
e99b875
f1e7e02
98b382d
d4a222c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This R bound basically means "deserializes to an owned type", right?
Maybe we could have a trait for that with supertrait
for<'r> DeserializeRow<'r, 'r> + 'static
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this idea. For me, the fact that a type is
'static
is completely independent of theDeserializeRow
implementation, and we shouldn't add another name to mean both of those things. Mentioning this in a straightforward way is the clearest.