-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CQL Vector type #1022
base: main
Are you sure you want to change the base?
Support CQL Vector type #1022
Conversation
See the following report for details: cargo semver-checks output
|
Hi @pkolaczk I'm very happy for you to take on the final part of this work. I also took some ideas from your PreCqlType implementation, thanks! |
Heads up that while working with vector types I've discovered that even the official java driver has issues with them, it only supports vectors of int, long, float and double. I've demonstrated the issues here: https://github.com/rukai/cassandra_vector_bug/blob/main/src/main/java/com/mycompany/app/App.java |
a7d851e
to
dc4bc3d
Compare
f65310c
to
f3eb389
Compare
8e89a68
to
d18f001
Compare
Internally only vectors of 32-bit floats are supported. This is what the index uses. There is no point in supporting other types in the driver at the moment. |
Can you give me a few hints on how do I add tests to this work so I can get this moving forward? |
@@ -112,6 +117,52 @@ pub enum CqlValue { | |||
Varint(CqlVarint), | |||
} | |||
|
|||
|
|||
#[derive(Clone, Debug, PartialEq)] | |||
pub struct DropOptimizedVec<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkolaczk I'm curious, do you have a microbenchmark that suggests this does anything different to a regular Vec<T>
on release mode?
Fixes #1014
Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.