Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tokio version bounds #1019

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Jun 24, 2024

This is fine now since tokio-rs/tokio#6610 is resolved via becheran/ntest#28 which has now been released in ntest 0.9.3
This PR also bumps the itertools + base64 versions, since they are trivial upgrades

The latest git main branch of scylla-rust-driver fails to build in my project due to the version restriction, these kinds of version restrictions often cause problems like this, so it would be bad for such a version restriction to end up in a release.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Copy link

github-actions bot commented Jun 24, 2024

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 568eaf4

@rukai rukai force-pushed the remove_tokio_version_bounds branch 2 times, most recently from ef05d7d to 38f644b Compare June 24, 2024 05:26
@Lorak-mmk
Copy link
Collaborator

Thanks for the contribution!
If the issue was resolved via a new version of ntest, then

  1. There is no need to bump minimum version of Tokio and we could still use version = "1.34", right?
  2. ntest should be bumped to 0.9.3 to avoid problems for people who have lockfiles locally.

(nit) could you split itrertools + base64 update to a separate commit?

@rukai rukai force-pushed the remove_tokio_version_bounds branch 3 times, most recently from ba02664 to 42a271f Compare June 24, 2024 07:25
@rukai
Copy link
Contributor Author

rukai commented Jun 24, 2024

The feedback should be addressed now

@Lorak-mmk
Copy link
Collaborator

What I meant was to also update ntest in Cargo.toml files - we need to require new version because old version doesn't work with new Tokio.
After you bump those versions I think it's good to go

rukai added 2 commits June 25, 2024 08:28
This is fine since tokio-rs/tokio#6610 is
resolved via becheran/ntest#28 which has now
been released in ntest 0.9.3
@rukai rukai force-pushed the remove_tokio_version_bounds branch from 42a271f to 568eaf4 Compare June 24, 2024 22:28
@rukai
Copy link
Contributor Author

rukai commented Jun 24, 2024

I've now updated the PR to also update ntest in the Cargo.toml not just in the Cargo.lock.msrv

@Lorak-mmk Lorak-mmk merged commit 1386776 into scylladb:main Jun 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants