Skip to content

Commit

Permalink
ci: fix semver checks by pinning working dep version
Browse files Browse the repository at this point in the history
It appears that the update of tame-index from 0.12.1 to 0.12.2 contains
API-breaking changes, which result in cargo-semver-checks compilation
error. To work around this, a custom setup of cargo-semver-checks is
done that pins tame-index to 0.12.1 version.

This should be reverted once tame-index issues 0.12.3 that reverts back
the breaking changes.
  • Loading branch information
wprzytula committed Jul 31, 2024
1 parent 73ecf74 commit 53de431
Showing 1 changed file with 27 additions and 3 deletions.
30 changes: 27 additions & 3 deletions .github/workflows/semver_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,21 @@ jobs:
run: rustup update
- name: Install semver-checks
# Official action uses binary releases fetched from GitHub
# If this pipeline becomes too slow, we should do this too
run: cargo install cargo-semver-checks --no-default-features
# If this pipeline becomes too slow, we should do this too.
#
# This works around the Semver violation in tame-index 0.12.2 that renders
# cargo-semver-checks incompilable. Once it gets fixed, revert back
# to using the newest release without customisations.
run: |
pushd ..
git clone https://github.com/obi1kenobi/cargo-semver-checks.git
cd cargo-semver-checks
git checkout v0.32.0
sed -i '0,/tame-index = { version = "0.12"/s//tame-index = { version = "=0.12.1"/' Cargo.toml
cargo build -r
cargo install --no-default-features --path .
popd
- name: Verify the API compatibilty with PR base
id: semver-pr-check
run: |
Expand Down Expand Up @@ -147,6 +160,17 @@ jobs:
- name: Update rust toolchain
run: rustup update
- name: Install semver-checks
run: cargo install cargo-semver-checks --no-default-features
# This works around the Semver violation in tame-index 0.12.2 that renders
# cargo-semver-checks incompilable. Once it gets fixed, revert back
# to using the newest release without customisations.
run: |
pushd ..
git clone https://github.com/obi1kenobi/cargo-semver-checks.git
cd cargo-semver-checks
git checkout v0.32.0
sed -i '0,/tame-index = { version = "0.12"/s//tame-index = { version = "=0.12.1"/' Cargo.toml
cargo build -r
cargo install --no-default-features --path .
popd
- name: Run semver-checks to see if it agrees with version updates
run: make semver-version

0 comments on commit 53de431

Please sign in to comment.