Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2024.1] fix(logcollector): silent errors from saving of schema details #9456

Draft
wants to merge 1 commit into
base: branch-2024.1
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 2, 2024

Silent collection schema details failure.
Now it fails in the K8S test. Need be fixed later

Collection schema is presented by #9329

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

(cherry picked from commit c177a65)

Parent PR: #9450

Silent collection schema details failure.
Now it fails in the K8S test. Need be fixed later

(cherry picked from commit c177a65)

# Conflicts:
#	sdcm/tester.py
Copy link
Author

mergify bot commented Dec 2, 2024

Cherry-pick of c177a65 has failed:

On branch mergify/bp/branch-2024.1/pr-9450
Your branch is up to date with 'origin/branch-2024.1'.

You are currently cherry-picking commit c177a65ff.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   sdcm/tester.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot marked this pull request as draft December 2, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant