test(performance): add latency with nemesis and disable RBNO #9440
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'scylla-enterprise-perf-regression-latency-650gb-with-nemesis' test with RBNO disabled
juliayakovlev
force-pushed
the
perf_with_nemesis_rbno_disabled
branch
from
165bf6d
to
541f938
Compare
roydahan
reviewed
Dec 1, 2024
| perfRegressionParallelPipeline( | ||
| backend: "aws", | ||
| test_name: "performance_regression_test.PerformanceRegressionTest", | ||
| test_config: """["test-cases/performance/perf-regression-latency-650gb-with-nemesis.yaml", "configurations/tablets_disabled.yaml", "configurations/disable_kms.yaml","configurations/disable_rbno.yaml"]""", |
There was a problem hiding this comment.
tablets disabled - got me rethinking of it.
It was mostly relevant for us only for the runs of 2024.1, possibly for 2024.2.
However, longer term we don't want to run with tablets disabled.
However, with tablets I think this test is not needed (it doesn't use RBNO AFAIK, does it?).
There was a problem hiding this comment.
As I found RBNO is used when tablets enabled
There was a problem hiding this comment.
in the 2022.2 and 2023.1 versions RBNO is enabled by default for replace operation only
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'scylla-enterprise-perf-regression-latency-650gb-with-nemesis' test with RBNO disabled
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)