Make it possible for NewSession not to block #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkropachev I've added this as a draft, I am not sure which way to go:
|
dkropachev
reviewed
Jan 2, 2025
sylwiaszunejko
force-pushed
the
create-session-non-block
branch
from
f366782 to
8d25897
Compare
For some use-cases it is helpful to be able to start the initialization of the Session, but not neccesarly wait for it to finish. To accomodate this need this commit adds new non blocking API. If the user tries to query Session that isn't initialized yet, the new ErrSessionNotReady will be returned.
sylwiaszunejko
force-pushed
the
create-session-non-block
branch
from
8d25897 to
2d574ef
Compare
dkropachev
requested changes
Jan 3, 2025
Comment on lines
+219
to
+228
| go func() { | ||
| if initErr := s.init(); initErr != nil { | ||
| s.sessionStateMu.Lock() | ||
| s.initErr = fmt.Errorf("gocql: unable to create session: %v", initErr) | ||
| s.sessionStateMu.Unlock() | ||
| } | ||
|
|
||
| s.readyCh <- s.initErr | ||
| close(s.readyCh) | ||
| }() |
There was a problem hiding this comment.
Can you please make this behavior optional, preserving old behavior by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is the following:
Fixes: #234