-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extends gocql API for scylla shard aware info #164
Conversation
ebcdfc0
to
2376551
Compare
77c6a2d
to
13a7697
Compare
@moguchev Please squash your commits into set of independent changes. Correction commit affecting files changed in other PR commit should be squashed. |
13a7697
to
2a9aa74
Compare
done |
@avelanarius Could you please review this PR to ensure everything is correct? |
2a9aa74
to
2d81d51
Compare
I've changed |
Also it's better to use |
@avelanarius ping |
@dkropachev Could you look at this PR? |
@moguchev , thanks for contribution, I see you put lots of effort into it. @sylwiaszunejko, I think we should not merge it as it is, functionally it is correct, except not covering tablets feature.
Overall case is very valueable, not only for this particular driver. UpdateJust FYI: rust-driver related issues: scylladb/scylla-rust-driver#468, scylladb/scylla-rust-driver#975, scylladb/scylla-rust-driver#944 |
Thanks! I hope you'll add this in API |
Thanks for you contribution, it give us very good clue, I have created an issue based on this PR, we would be happy to see your recommendations/comments there. |
In our case, we encountered a problem when we need to insert and read more than 500 different keys (from different partitions) at a time in scyllaDB in one user request.
The insertion (BATCH request) still worked well, but reading queries (SELECT WHERE IN) left much to be desired.
We needed to extend the gocql API to be able to split keys/queries across hosts (or shards) on the side of our application and send queries to scyllaDB. This allowed us to reduce response time.
It might be useful to give this functionality. Well, or you can suggest a more elegant implementation than what I wrote :)