fix (libzkp): free Rust CString by from_raw
#998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #998 +/- ##
========================================
Coverage 48.13% 48.14%
========================================
Files 100 100
Lines 10591 10591
========================================
+ Hits 5098 5099 +1
+ Misses 5071 5070 -1
Partials 422 422
Flags with carried forward coverage won't be shown. Click here to find out more. |
silathdiir
force-pushed
the
libkzp-free-c-chars
branch
from
822fdc6 to
0da926f
Compare
lispc
previously approved these changes
Oct 23, 2023
|
btw do you need to fix this in l2geth ccc? |
Merged
13 tasks
silathdiir
force-pushed
the
libkzp-free-c-chars
branch
from
d380e1e to
1fd5038
Compare
georgehao
reviewed
Oct 23, 2023
silathdiir
changed the title
from_rawfrom_raw
0xmountaintop
approved these changes
Oct 24, 2023
georgehao
approved these changes
Oct 24, 2023
flyq
reviewed
Mar 14, 2024
| if cfg.ProofType == message.ProofTypeBatch { | ||
| C.init_batch_prover(paramsPathStr, assetsPathStr) | ||
| rawVK = C.get_batch_vk() | ||
| } else if cfg.ProofType == message.ProofTypeChunk { | ||
| C.init_chunk_prover(paramsPathStr, assetsPathStr) | ||
| rawVK = C.get_chunk_vk() | ||
| } | ||
| defer C.free_c_chars(rawVK) |
There was a problem hiding this comment.
the rawVK is newed in go code, so it should be released in defer C.free(unsafe.Pointer(rawVK))?
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Proof results and VKs are returned by vec_to_c_char or string_to_c_char as
*const c_charwhich calls CString::into_raw, reference its doc, the C ptr must be freed byCString::from_raw(memory leak otherwise).free_c_chars.Test
The memory available could restore (
983 -> 983) when running a loop (50 chunks from yesterday to morning of today).The chunk-prover and batch-prover are created for each run of loop.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?