Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(zkp): v0.13 #1487

Conversation

lispc
Copy link
Contributor

@lispc lispc commented Aug 20, 2024

libzkp batch.rs needs some updates to support dual version of circuits.

change edison => darwin2?

assets scroll-tech/scroll-prover#336

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@lispc lispc marked this pull request as ready for review August 20, 2024 07:40
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.90%. Comparing base (ba4f61c) to head (7b036fc).
Report is 13 commits behind head on feat-coordinator-add-blob-bytes-in-batch-proving-task.

Additional details and impacted files
@@                                    Coverage Diff                                    @@
##           feat-coordinator-add-blob-bytes-in-batch-proving-task    #1487      +/-   ##
=========================================================================================
+ Coverage                                                  51.88%   51.90%   +0.01%     
=========================================================================================
  Files                                                        156      156              
  Lines                                                      12704    12712       +8     
=========================================================================================
+ Hits                                                        6592     6598       +6     
- Misses                                                      5546     5548       +2     
  Partials                                                     566      566              
Flag Coverage Δ
common 47.35% <ø> (ø)
coordinator 16.89% <ø> (ø)
database 42.85% <ø> (ø)
rollup 55.68% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao georgehao merged commit 1f7bef9 into feat-coordinator-add-blob-bytes-in-batch-proving-task Aug 23, 2024
17 checks passed
@georgehao georgehao deleted the chore/zkp-v0.13 branch August 23, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants