Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix(bridge-history): update l2geth version #1102

Closed
wants to merge 6 commits into from

Conversation

0xmountaintop
Copy link
Contributor

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@colinlyguo colinlyguo self-requested a review January 31, 2024 02:27
@0xmountaintop 0xmountaintop marked this pull request as ready for review January 31, 2024 02:27
@0xmountaintop 0xmountaintop changed the title Fix update l2geth sdk 2 fix(bridge-history): update l2geth version Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ad7947) 57.05% compared to head (b4344de) 57.05%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1102   +/-   ##
========================================
  Coverage    57.05%   57.05%           
========================================
  Files          150      150           
  Lines        11160    11160           
========================================
  Hits          6367     6367           
  Misses        4349     4349           
  Partials       444      444           
Flag Coverage Δ
bridge-history-api 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xmountaintop 0xmountaintop changed the title fix(bridge-history): update l2geth version WIP fix(bridge-history): update l2geth version Jan 31, 2024
@0xmountaintop
Copy link
Contributor Author

fixed in scroll-tech/go-ethereum#623 & scroll-tech/go-ethereum#626 & #1103.

closed.

@0xmountaintop 0xmountaintop deleted the fix-update-l2geth-sdk-2 branch February 19, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant