Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-history): update l2geth version #1101

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jan 31, 2024

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo marked this pull request as ready for review January 31, 2024 01:08
@colinlyguo colinlyguo changed the title fix(bridge-history): update l2geth sdk fix(bridge-history): update l2geth version Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bab1841) 57.05% compared to head (c0594cf) 57.05%.

❗ Current head c0594cf differs from pull request most recent head dcaf40c. Consider uploading reports for the commit dcaf40c to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1101   +/-   ##
========================================
  Coverage    57.05%   57.05%           
========================================
  Files          150      150           
  Lines        11160    11160           
========================================
  Hits          6367     6367           
  Misses        4349     4349           
  Partials       444      444           
Flag Coverage Δ
bridge-history-api 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Jan 31, 2024
@0xmountaintop 0xmountaintop merged commit 0ad7947 into develop Jan 31, 2024
@0xmountaintop 0xmountaintop deleted the fix-update-l2geth-sdk branch January 31, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants