-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bridge-history): incorrect status update and duplicated failed txs #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1088 +/- ##
===========================================
- Coverage 56.49% 56.49% -0.01%
===========================================
Files 149 149
Lines 11114 11115 +1
===========================================
Hits 6279 6279
- Misses 4406 4407 +1
Partials 429 429
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
georgehao
previously approved these changes
Jan 22, 2024
colinlyguo
force-pushed
the
fix-bridge-history-backend
branch
from
January 22, 2024 17:28
d7da13f
to
7bb2c34
Compare
zimpha
reviewed
Jan 23, 2024
zimpha
approved these changes
Jan 23, 2024
georgehao
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
This PR fixes several bugs:
_to.call
can fail withOOG
and emitFailedRelayedMessage
, in this case, retry will help.replayMessage
scenario.InsertFailedGatewayRouterTxs
to avoid inserting same transaction multiple times, which is very unfriendly to pagination.Bridge cost optimization incompatibility:
5. Fix 1: EOA -> gateway router case.
6. Fix 2: EOA -> multisig -> gateway router case.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?