Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format without placeholder #1048

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

machinly
Copy link
Contributor

Purpose or design rationale of this PR

Some Fatalf functions lack placeholders, and the underlying implementation uses Fprintf. This could lead to issues with properly printing error messages.

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b8c463f) 48.90% compared to head (73785c3) 48.90%.

Files Patch % Lines
bridge-history-api/utils/logger.go 0.00% 1 Missing ⚠️
common/utils/logger.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1048   +/-   ##
========================================
  Coverage    48.90%   48.90%           
========================================
  Files          158      158           
  Lines        12710    12710           
========================================
  Hits          6216     6216           
  Misses        6064     6064           
  Partials       430      430           
Flag Coverage Δ
bridge-history-api 11.11% <0.00%> (ø)
common 55.05% <0.00%> (ø)
coordinator 18.91% <ø> (ø)
database 42.85% <ø> (ø)
rollup 66.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xmountaintop 0xmountaintop merged commit 1264f82 into scroll-tech:develop Dec 14, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants