fix: avoid duplicated batch updates #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated-batches-update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix-bridge-history-api-write-db #1029 +/- ##
==================================================================
Coverage ? 56.27%
==================================================================
Files ? 88
Lines ? 9000
Branches ? 0
==================================================================
Hits ? 5065
Misses ? 3516
Partials ? 419
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
georgehao
reviewed
Dec 11, 2023
Comment on lines
304
to
314
| // Perform a final check to confirm the existence of the key to ensure consistency between ZCard and ZRange data reads. | ||
| exists, err := h.redis.Exists(ctx, cacheKey).Result() | ||
| if err != nil { | ||
| log.Error("failed to check if key exists", "error", err) | ||
| return nil, 0, false, err | ||
| } | ||
|
|
||
| // If the key does not exist, we consider it a cache miss and return accordingly. | ||
| if exists == 0 { | ||
| return nil, 0, false, nil | ||
| } |
There was a problem hiding this comment.
it's necessary because if the key does not exist, it will return nil value, and cannot differentiate:
- cache key exists but the value is nil.
- cache key does not exist.
There was a problem hiding this comment.
i think just check total or value whether empty
There was a problem hiding this comment.
Yeah. but if the txs under the address are empty, it would be treated as "key not found", too.
georgehao
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Currently, the batch index information is not updated repeatedly within the buffer until the arrival of the next message. In situations where messages are sparse, this could significantly reduce the speed of the L1 fetcher.
An example (in block 4259 to block 4345 there is no message):
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?