-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new bridge history apis #1024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinlyguo
added
enhancement
New feature or request
breaking-change
bump-version
Bump the version tag for deployment
labels
Dec 3, 2023
colinlyguo
force-pushed
the
fix-bridge-history-api-write-db
branch
from
December 3, 2023 18:22
a8e3537
to
13208fa
Compare
colinlyguo
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Dec 3, 2023
colinlyguo
force-pushed
the
fix-bridge-history-api-write-db
branch
7 times, most recently
from
December 4, 2023 07:59
e2b5c13
to
87fa3d6
Compare
colinlyguo
force-pushed
the
fix-bridge-history-api-write-db
branch
2 times, most recently
from
December 4, 2023 12:08
f09f43c
to
a45ddd1
Compare
colinlyguo
force-pushed
the
fix-bridge-history-api-write-db
branch
from
December 6, 2023 04:32
f18eb31
to
f011fd5
Compare
georgehao
reviewed
Dec 6, 2023
georgehao
reviewed
Dec 6, 2023
georgehao
reviewed
Dec 6, 2023
georgehao
reviewed
Dec 6, 2023
georgehao
reviewed
Dec 6, 2023
bridge-history-api/internal/controller/api/history_controller.go
Outdated
Show resolved
Hide resolved
Co-authored-by: colinlyguo <[email protected]>
Co-authored-by: colin <[email protected]>
georgehao
previously approved these changes
Dec 16, 2023
colinlyguo
force-pushed
the
fix-bridge-history-api-write-db
branch
from
December 17, 2023 10:21
88cd3cc
to
fae11cc
Compare
0xmountaintop
approved these changes
Dec 28, 2023
georgehao
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
/txs?address=0x0&page_size=10&page=1
/l2/withdrawals?address=0x0&page_size=10&page=1
/l2/unclaimed/withdrawals?address=0x0&page_size=10&page=1
/txsbyhashes
A more detailed doc: https://www.notion.so/scrollzkp/Bridge-History-APIs-ac136e1ac51e4292a66a1153a79d79bb
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?