Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add address(0) check for constructors. #1010

Merged
merged 5 commits into from
Dec 11, 2023
Merged

refactor: add address(0) check for constructors. #1010

merged 5 commits into from
Dec 11, 2023

Conversation

lukema95
Copy link
Contributor

@lukema95 lukema95 commented Nov 7, 2023

Purpose or design rationale of this PR

I think it's necessary to add a check for address(0) in the constructors. Initializing a state variable with address(0) can lead to unintended behavior and vulnerabilities in the contract.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@Thegaram Thegaram requested a review from zimpha November 7, 2023 09:28
@zimpha
Copy link
Member

zimpha commented Nov 7, 2023

looks good to me

@0xmountaintop 0xmountaintop merged commit bf2692b into scroll-tech:develop Dec 11, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants