Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rollup-relayer): tweak finalize batch logs #1009

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Nov 6, 2023

Purpose or design rationale of this PR

The logs are confusing now, make it more clear.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Nov 6, 2023
@colinlyguo colinlyguo self-assigned this Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1009 (50744d3) into develop (0243c86) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head 50744d3 differs from pull request most recent head 56838e3. Consider uploading reports for the commit 56838e3 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1009      +/-   ##
===========================================
- Coverage    48.01%   48.00%   -0.01%     
===========================================
  Files          101      101              
  Lines        10669    10671       +2     
===========================================
  Hits          5123     5123              
- Misses        5118     5120       +2     
  Partials       428      428              
Flag Coverage Δ
rollup 66.02% <33.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
rollup/internal/controller/relayer/l2_relayer.go 41.57% <33.33%> (-0.16%) ⬇️

@colinlyguo colinlyguo merged commit 486c7ee into develop Nov 6, 2023
@colinlyguo colinlyguo deleted the fix-rollup-relayer-logs branch November 6, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants