Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup-relayer): auto finalize batch when timeout in test env #1008

Merged

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Nov 6, 2023

Purpose or design rationale of this PR

cherry-pick #1004

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1008 (b8c11f0) into develop (50040a1) will increase coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 37.81%.

@@             Coverage Diff             @@
##           develop    #1008      +/-   ##
===========================================
+ Coverage    48.00%   48.01%   +0.01%     
===========================================
  Files          101      101              
  Lines        10640    10669      +29     
===========================================
+ Hits          5108     5123      +15     
- Misses        5109     5118       +9     
- Partials       423      428       +5     
Flag Coverage Δ
rollup 66.07% <37.81%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
rollup/abi/bridge_abi.go 100.00% <ø> (ø)
rollup/internal/config/relayer.go 68.96% <ø> (ø)
rollup/internal/orm/batch.go 56.80% <66.66%> (ø)
rollup/internal/controller/sender/sender.go 66.39% <0.00%> (-0.37%) ⬇️
rollup/internal/controller/relayer/l1_relayer.go 78.78% <0.00%> (-2.47%) ⬇️
rollup/internal/controller/relayer/l2_relayer.go 41.73% <38.73%> (+1.00%) ⬆️

@georgehao georgehao merged commit 0243c86 into develop Nov 6, 2023
11 checks passed
@georgehao georgehao deleted the feat/rollup-relayer-auto-finalize-batch-in-test-env branch November 6, 2023 06:54
@colinlyguo colinlyguo self-assigned this Nov 6, 2023
@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants