remove unused logic in L1GatewayRouter

scroll-tech · Jan 28, 2024 · c06f705 · c06f705
1 parent bab1841
commit c06f705
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/contracts/src/L1/gateways/L1GatewayRouter.sol b/contracts/src/L1/gateways/L1GatewayRouter.sol
@@ -81,9 +81,11 @@ contract L1GatewayRouter is OwnableUpgradeable, IL1GatewayRouter {
     ///
     /// @dev The parameters `_ethGateway` is no longer used.
     ///
-    /// @param _ethGateway The address of L1ETHGateway contract.
     /// @param _defaultERC20Gateway The address of default ERC20 Gateway contract.
-    function initialize(address _ethGateway, address _defaultERC20Gateway) external initializer {
+    function initialize(
+        address, /*_ethGateway*/
+        address _defaultERC20Gateway
+    ) external initializer {
         OwnableUpgradeable.__Ownable_init();
 
         // it can be zero during initialization
@@ -92,11 +94,13 @@ contract L1GatewayRouter is OwnableUpgradeable, IL1GatewayRouter {
             emit SetDefaultERC20Gateway(address(0), _defaultERC20Gateway);
         }
 
+        /* comment out since it is no longer used.
         // it can be zero during initialization
         if (_ethGateway != address(0)) {
             ethGateway = _ethGateway;
             emit SetETHGateway(address(0), _ethGateway);
         }
+        */
     }
 
     /*************************

diff --git a/contracts/src/test/L1GatewayRouter.t.sol b/contracts/src/test/L1GatewayRouter.t.sol
@@ -86,7 +86,6 @@ contract L1GatewayRouterTest is L1GatewayTestBase {
     }
 
     function testInitialized() public {
-        assertEq(address(l1ETHGateway), router.ethGateway());
         assertEq(address(l1StandardERC20Gateway), router.defaultERC20Gateway());
         assertEq(
             factory.computeL2TokenAddress(address(l2StandardERC20Gateway), address(l1Token)),