Remove unused and broken strategy matrix #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgoergens
requested review from
kunxian-xia and
hero78119
and removed request for
kunxian-xia
Merged
matthiasgoergens
changed the title
roylou
approved these changes
Dec 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
Right now a simple `cargo build` fails. So let's fix that. This PR also disentangles `ceno_rt`, so that we can work on building guest programs much easier. Update: I extracted the remove of the target matrix into #725 for ease of review. This PR also enables debug assertions for our tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #719 for ease of review.
Our strategy matrix only has one entry, so we might as well not use it.
Also, using
riscv32im-unknown-none-elfas the target anywhere actually fails. As an example you can tryTARGET=riscv32im-unknown-none-elf cargo make clippyon currentmaster.