Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/jalr-degree #504

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix/jalr-degree #504

merged 1 commit into from
Oct 30, 2024

Conversation

naure
Copy link
Collaborator

@naure naure commented Oct 30, 2024

Issue #502

  • Check constraint degree in MockProver.
  • Implement JALR with degree 2 using an intermediate witness.
  • Implement JALR more efficiently when overflow is not required.

@naure naure requested review from kunxian-xia and bgillesp October 30, 2024 12:26
@naure naure linked an issue Oct 30, 2024 that may be closed by this pull request
Degree >2 expression in JALR #502
Closed
matthiasgoergens
matthiasgoergens reviewed Oct 30, 2024
View reviewed changes
ceno_zkvm/src/scheme/mock_prover.rs
@@ -438,6 +457,14 @@ impl<'a, E: ExtensionField + Hash> MockProver<E> {
.chain(&cb.cs.assert_zero_sumcheck_expressions_namespace_map),
)
{
if expr.degree() > MAX_CONSTRAINT_DEGREE {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

kunxian-xia
kunxian-xia approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@kunxian-xia kunxian-xia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunxian-xia kunxian-xia merged commit d9b443a into master Oct 30, 2024
6 checks passed
@kunxian-xia kunxian-xia deleted the fix/jalr-degree branch October 30, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasgoergens matthiasgoergens matthiasgoergens left review comments

@kunxian-xia kunxian-xia kunxian-xia approved these changes

@bgillesp bgillesp Awaiting requested review from bgillesp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Degree >2 expression in JALR
3 participants
@naure @matthiasgoergens @kunxian-xia