Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instruction category is a function of opcode #496

Closed
wants to merge 2 commits into from
Closed

Instruction category is a function of opcode #496

wants to merge 2 commits into from

Conversation

matthiasgoergens
Copy link
Collaborator

@matthiasgoergens matthiasgoergens commented Oct 30, 2024 •
edited
Loading

So we don't need to cache it.

@naure
Copy link
Collaborator

naure commented Oct 30, 2024

This implementation is based on a lookup table, why rewrite it with a different technique?

@matthiasgoergens
Copy link
Collaborator Author

matthiasgoergens commented Nov 4, 2024 •
edited
Loading

This implementation is based on a lookup table, why rewrite it with a different technique?

We are storing redundant information in InsnCodes. It's still a lookup table in the new implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naure naure Awaiting requested review from naure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiasgoergens @naure