Recognise that namespace can't fail
#490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least `ConstraintSystem::namespace` won't fail on its own. But it might fail, if the circus construction function (or so) you are passing to fails. The new type reflects that.
matthiasgoergens
requested review from
KimiWu123,
kunxian-xia,
hero78119 and
bgillesp
and removed request for
KimiWu123,
kunxian-xia and
hero78119
| cb: impl FnOnce(&mut ConstraintSystem<E>) -> Result<T, ZKVMError>, | ||
| ) -> Result<T, ZKVMError> { | ||
| cb: impl FnOnce(&mut ConstraintSystem<E>) -> T, | ||
| ) -> T { |
There was a problem hiding this comment.
Specifically, this works exactly as before, when the 'new' T happens to be a Result<_, ZKVMError>.
hero78119
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least
ConstraintSystem::namespacewon't fail on its own. But it might fail, if the circus construction function (or so) you are passing to fails.The new type reflects that.
Extracted from #466 and addressing https://github.com/scroll-tech/ceno/pull/455/files#r1818907561
This will lead to a lot of clean up down the line, but I want to keep this PR small.