Recognise create_witin can't fail
#488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgoergens
force-pushed
the
matthias/remove-wrapper-1
branch
from
0f71c85 to
5176ab2
Compare
bgillesp
reviewed
Oct 28, 2024
There was a problem hiding this comment.
If everyone is happy with the scope of this simplification to the WitIn constructor (I think it's a reasonable change), the PR looks good to me overall.
One revision requested: make the id increment operation checked or panicking in CircuitBuilder::create_witin, and possibly extend the id type to 32 bits.
bgillesp
approved these changes
Oct 29, 2024
kunxian-xia
reviewed
Oct 29, 2024
| let wit_in = WitIn { | ||
| id: { | ||
| let id = self.num_witin; | ||
| self.num_witin += 1; | ||
| self.num_witin = self.num_witin.strict_add(1); |
There was a problem hiding this comment.
Isn't the strict_add a nightly-only experimental API?
There was a problem hiding this comment.
Yes, it is. We already use a few other features like that.
This specific one would be easy to remove in the future, if we ever want to move to a stable version that doesn't have it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #466 and addressing https://github.com/scroll-tech/ceno/pull/455/files#r1818907561