Remove (almost) all dead code #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,16 +3,6 @@ use ff_ext::ExtensionField; | |||
| use itertools::izip; | |||
| use simple_frontend::structs::{CellId, CircuitBuilder}; | |||
|
|
|||
| // TODO(Matthias): Check whether we need this function. | |||
| #[allow(dead_code)] | |||
| pub(crate) fn i64_to_base_field<E: ExtensionField>(x: i64) -> E::BaseField { | |||
There was a problem hiding this comment.
This is a copy and paste from singer-utils/src/chip_handler/range.rs (or vice versa).
bgillesp
approved these changes
Oct 28, 2024
| /// A helper function to build eq(x, r) via dynamic programing tricks. | ||
| /// This function takes 2^num_var iterations, and per iteration with 1 multiplication. | ||
| #[allow(dead_code)] | ||
| fn build_eq_x_r_helper<E: ExtensionField>(r: &[E], buf: &mut [Vec<E>; 2]) { |
There was a problem hiding this comment.
Note for general reference: the current implementation of build_eq_x_r uses a similar function build_eq_x_r_helper_sequential, so the removed unused code here looks to be redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we review most of our code marked as dead.
Mostly either we remove the now unnecessary label, or we remove the code.