Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Unchanged files with check annotations' spam #338

Merged
merged 1 commit into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gkr/src/circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ where
in_eq_vec: &[E],
challenges: &HashMap<ChallengeConst, Vec<E::BaseField>>,
) -> E;
// TODO(Matthias, by 2024-11-01): review whether we need this function after all.
#[allow(dead_code)]
fn fix_out_variables(
&self,
in_size: usize,
Expand Down
4 changes: 2 additions & 2 deletions gkr/src/gadgets/keccak256.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ use ff::Field;
use ff_ext::ExtensionField;
use itertools::{izip, Itertools};
use multilinear_extensions::{
mle::{DenseMultilinearExtension, IntoMLE},
virtual_poly_v2::ArcMultilinearExtension,
mle::DenseMultilinearExtension, virtual_poly_v2::ArcMultilinearExtension,
};
use simple_frontend::structs::CircuitBuilder;
use std::iter;
Expand Down Expand Up @@ -467,6 +466,7 @@ pub fn prove_keccak256<'a, E: ExtensionField>(
#[cfg(test)]
{
use crate::structs::CircuitWitness;
use multilinear_extensions::mle::IntoMLE;
let all_zero: Vec<DenseMultilinearExtension<E>> = vec![
vec![E::BaseField::ZERO; 25 * 64],
vec![E::BaseField::ZERO; 17 * 64],
Expand Down
4 changes: 2 additions & 2 deletions gkr/src/prover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ use transcript::Transcript;
use crate::{
entered_span, exit_span,
structs::{
Circuit, CircuitWitness, GKRInputClaims, IOPProof, IOPProverState, IOPProverStepMessage,
PointAndEval, SumcheckStepType,
Circuit, CircuitWitness, GKRInputClaims, IOPProof, IOPProverState, PointAndEval,
SumcheckStepType,
},
tracing_span,
};
Expand Down
1 change: 0 additions & 1 deletion gkr/src/prover/phase1_output.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ use ff::Field;
use ff_ext::ExtensionField;
use itertools::{izip, Itertools};
use multilinear_extensions::{
commutative_op_mle_pair,
mle::{
DenseMultilinearExtension, InstanceIntoIteratorMut, IntoInstanceIter, IntoInstanceIterMut,
},
Expand Down
2 changes: 2 additions & 0 deletions gkr/src/prover/phase2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ impl<E: ExtensionField> IOPProverState<E> {
< lo_in_num_vars
{
Arc::new(
// TODO(Matthias, by 2024-11-01): review whether we can redesign this API to avoid the deprecated resize_ranged
#[allow(deprecated)]
circuit_witness.layers_ref()[layer_id as usize + 1].resize_ranged(
1 << hi_num_vars,
1 << lo_in_num_vars,
Expand Down
1 change: 1 addition & 0 deletions gkr/src/prover/phase2_input.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ impl<E: ExtensionField> IOPProverState<E> {
virtual_poly.merge(&tmp);
}

#[allow(deprecated)]
let (sumcheck_proofs, prover_state) =
SumcheckStateV2::prove_parallel(virtual_poly, transcript);
let eval_point = sumcheck_proofs.point.clone();
Expand Down
2 changes: 2 additions & 0 deletions gkr/src/prover/phase2_linear.rs
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ impl<E: ExtensionField> IOPProverState<E> {
virtual_poly_1.merge(&tmp);
}

// TODO(Matthias, by 2024-11-01): review whether we can replace this function.
#[allow(deprecated)]
let (sumcheck_proof_1, prover_state) =
SumcheckStateV2::prove_parallel(virtual_poly_1, transcript);
let eval_point_1 = sumcheck_proof_1.point.clone();
Expand Down
4 changes: 1 addition & 3 deletions gkr/src/structs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ use std::{

use ff_ext::ExtensionField;
use goldilocks::SmallField;
use multilinear_extensions::{
mle::ArcDenseMultilinearExtension, virtual_poly_v2::ArcMultilinearExtension,
};
use multilinear_extensions::virtual_poly_v2::ArcMultilinearExtension;
use serde::{Deserialize, Serialize, Serializer};
use simple_frontend::structs::{CellId, ChallengeConst, ConstantType, LayerId};

Expand Down
Loading