Add support for generic integer type conversions to Expression::Constant #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
approved these changes
Oct 9, 2024
hero78119
reviewed
Oct 9, 2024
hero78119
reviewed
Oct 9, 2024
hero78119
requested changes
Oct 9, 2024
hero78119
approved these changes
Oct 9, 2024
naure
reviewed
Oct 11, 2024
| impl_from_unsigned!(u8, u16, u32, u64, usize); | ||
|
|
||
| // Implement From trait for u128 separately since it requires explicit reduction | ||
| impl<F: SmallField, E: ExtensionField<BaseField = F>> From<u128> for Expression<E> { |
There was a problem hiding this comment.
Was this From<u128> really necessary? It is a lossy conversion therefore error-prone.
There was a problem hiding this comment.
The existing conversion from usize prior to this PR was already slightly lossy in this sense because the value has to be renormalized if between p_goldilocks and 2^64 - 1. The way I interpret the syntax (and the way it's implemented here) is "integer primitive types represent actual integers, and any conversion to a BaseField constant is by the 'reduce mod p' map", which seems natural.
|
Great move! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation only provides
From<usize>, which requires explicit type conversions in various locations. This PR provides support for type conversions for arbitrary primitive integer types, specifically:u8, u16, u32, u64, u128, usize, i8, i16, i32, i64, i128, isizeIn reference to this comment.