Remove broken and unused package singer-pro
#314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #313 Please restore `singer-pro` from the git history, if/when you need it again.
|
cc author @dreamATD for the more option :) I am fine with the decision for temporarily remove, and we can explore how singer-pro works in new design as a future task @matthiasgoergens how about we also creating an issue as memo to keep this on track for when singer-pro was remove and how to restore it? |
|
Thanks for having a look. I'd be happy to create such an issue. However, I have no clue what |
|
@dreamATD Any opinions? |
matthiasgoergens
added a commit
that referenced
this pull request
Oct 14, 2024
Extracted from #314 for easier review.
matthiasgoergens
added a commit
that referenced
this pull request
Oct 14, 2024
Extracted from #314 for easier review.
hero78119
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #313
Commit 0a40721 from #89 broke
singer-pro. At least judging by whethercargo checksucceeds. It even has a commit about that temporarily exclude singer-pro from default workspace members.Please restore
singer-profrom the git history, if/when you need it again.Also remove
singer/examples/add-v2-old-sc-bak.rswhich was broken by the same commit. The filename suggests it was kept around as a 'backup'? (Please, have some more faith in git's ability to keep history!)