Update mul_add result type #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
reviewed
Oct 4, 2024
| @@ -37,13 +37,13 @@ impl<E: ExtensionField, I: RIVInstruction> Instruction<E> for ShiftImmInstructio | |||
| circuit_builder: &mut CircuitBuilder<E>, | |||
| ) -> Result<Self::InstructionConfig, ZKVMError> { | |||
| let mut imm = UInt::new(|| "imm", circuit_builder)?; | |||
| let mut rd_written = UInt::new_unchecked(|| "rd_written", circuit_builder)?; | |||
| let mut rd_written = UInt::new(|| "rd_written", circuit_builder)?; | |||
There was a problem hiding this comment.
Soundness fix and principle: we need to have range check on written register value
|
Updated with
|
hero78119
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
mul_addfunction does not include intermediate limb values returned from multiplication.Also for assigning multiplication and addition result, it involves multiple lines. This PR replaces assignment in
divuwithassign_limb_with_carryandassign_limb_with_carry_auxiliarywhich simplifies the assignment code by abstracting assignment of limbs and carry using max carry value.