Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Display for Expression #299

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

zemse
Copy link
Collaborator

@zemse zemse commented Oct 2, 2024

  1. move fmt expr utils to expression module
  2. impl Display for Expression

For a complex Expression, println("{:?}", expr) prints a lot of stuff and it is difficult to comprehend.

This PR enables println("{}", expr) which uses fmt_expr that is implemented originally in mock prover.

Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for one nitpick, overall LGTM!

ceno_zkvm/src/expression.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hero78119 hero78119 enabled auto-merge (squash) October 2, 2024 15:54
@hero78119 hero78119 merged commit 5b7b3de into scroll-tech:master Oct 2, 2024
6 checks passed
@zemse zemse deleted the mock-prover branch October 8, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants