Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monomials with ScaledSum #275

Closed
wants to merge 2 commits into from
Closed

Monomials with ScaledSum #275

wants to merge 2 commits into from

Conversation

naure
Copy link
Collaborator

@naure naure commented Sep 24, 2024

There is this hack in the MockProver

let expr = expr.clone().neg().neg(); // TODO get_ext_field_vec doesn't work without this

which only works if the expression happens to use ScaledSum as produced by the * operator. So use that instead of Product.

But then is_monomial_form won’t recognize the zeros in ScaledSum, so add this support too.


Meanwhile, I chased the cause of this through this stack but I don’t know how to fix it:

@naure naure requested a review from hero78119 September 24, 2024 10:17
@naure naure changed the title monomial-mockprover Monomials with ScaledSum Sep 24, 2024
@naure
Copy link
Collaborator Author

naure commented Sep 24, 2024

Already included in another PR.

@naure naure closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant