Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is this hack in the MockProver
which only works if the expression happens to use
ScaledSum
as produced by the*
operator. So use that instead ofProduct
.But then
is_monomial_form
won’t recognize the zeros inScaledSum
, so add this support too.Meanwhile, I chased the cause of this through this stack but I don’t know how to fix it:
The hack: run_maybe_challenge
Code that wants an Ext not a Base field: get_ext_field_vec
Code that produces Ext or Base depending on complicated logic: wit_infer_by_expr