mockprover error hint #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
force-pushed
the
feat/mock_prover_hint_msg
branch
from
f0e59e8 to
5e418ef
Compare
hero78119
force-pushed
the
feat/mock_prover_hint_msg
branch
from
5e418ef to
576b33d
Compare
matthiasgoergens
approved these changes
Oct 10, 2024
| @@ -548,6 +548,15 @@ impl<'a, E: ExtensionField + Hash> MockProver<E> { | |||
| println!("======================================================"); | |||
| println!("Error: {} constraints not satisfied", errors.len()); | |||
|
|
|||
| println!( | |||
| r"Hints: | |||
| - If you encounter a constraint error that sporadically occurs in different environments | |||
There was a problem hiding this comment.
That sounds like we need to tighten up our constraints? Otherwise, a malicious prover might be able to exploit the UB?
There was a problem hiding this comment.
That sounds like we need to tighten up our constraints? Otherwise, a malicious prover might be able to exploit the UB?
It not related to constraints :) This problem just related to the witnesses where we assuming them to be zero and skip their assignment, but actually unassigned witnesses is "undefined behaviour" due to we enclosed MaybeUint when allocated vector.
There was a problem hiding this comment.
Oh, that makes sense.
Btw, why do we do these shenanigans? Have we done a benchmark to check whether MaybeUninit actually helps us?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.