Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/#132 divu opcode #266

Merged
merged 14 commits into from
Sep 25, 2024
Merged

feat/#132 divu opcode #266

merged 14 commits into from
Sep 25, 2024

Conversation

KimiWu123
Copy link
Contributor

close #132

@KimiWu123 KimiWu123 force-pushed the feat/#132-opcode-DIVU branch 3 times, most recently from 6e761a6 to 712d629 Compare September 23, 2024 09:44
@KimiWu123 KimiWu123 marked this pull request as ready for review September 23, 2024 09:47
@KimiWu123 KimiWu123 force-pushed the feat/#132-opcode-DIVU branch from 66be06b to ec87421 Compare September 24, 2024 03:57
@hero78119 hero78119 mentioned this pull request Sep 24, 2024
Merged
hero78119
hero78119 reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just having a quick went through

ceno_zkvm/src/uint.rs Outdated Show resolved Hide resolved
ceno_zkvm/src/instructions/riscv/divu.rs Outdated Show resolved Hide resolved
ceno_zkvm/src/instructions/riscv/r_insn.rs Show resolved Hide resolved
ceno_zkvm/src/instructions/riscv/divu.rs Outdated Show resolved Hide resolved
@KimiWu123 KimiWu123 requested a review from hero78119 September 24, 2024 06:26
hero78119
hero78119 reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per offline discuss, we can save massive limb effort on Uint read from register

ceno_zkvm/src/uint/arithmetic.rs Outdated Show resolved Hide resolved
ceno_zkvm/src/instructions/riscv/divu.rs Outdated Show resolved Hide resolved
@KimiWu123 KimiWu123 force-pushed the feat/#132-opcode-DIVU branch from 20d2266 to 713b2f7 Compare September 25, 2024 02:17
@hero78119 hero78119 force-pushed the feat/#132-opcode-DIVU branch from 63c507a to b0705f8 Compare September 25, 2024 02:59
@KimiWu123 KimiWu123 merged commit cf20fb0 into master Sep 25, 2024
6 checks passed
@KimiWu123 KimiWu123 deleted the feat/#132-opcode-DIVU branch September 25, 2024 05:32
hero78119 added a commit that referenced this pull request Sep 30, 2024
@KimiWu123 @hero78119
feat/#132 divu opcode (#266)
8538e89 
close #132

---------

Co-authored-by: sm.wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemse zemse zemse left review comments

@hero78119 hero78119 hero78119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DIVU
3 participants
@KimiWu123 @hero78119 @zemse