refactor/rename UInt #240
Merged
refactor/rename UInt #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
force-pushed
the
refactor/reanme-UInt
branch
from
d2ae3fc to
536613d
Compare
hero78119
pushed a commit
that referenced
this pull request
Sep 30, 2024
A quick PR, just rename the following 3 structues - UInt --> UIntLimbs - RegUInt --> UInt - UIntValue --> Value `RegUInt` is designed for constraint system and I think `UInt` is enough to represent it. `UIntValue` is designed for witness assignment and looks similiar with `RegUInt`. To avoid being confused for new comers, rename to `Vaule` (follow zkEVM's naming). After `RegUInt` being renamed, the original `UInt` conflicts with it so renaming the original `UInt` to `UIntLimbs`. cc @hero78119 and @kunxian-xia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick PR, just rename the following 3 structues
RegUIntis designed for constraint system and I thinkUIntis enough to represent it.UIntValueis designed for witness assignment and looks similiar withRegUInt. To avoid being confused for new comers, rename toVaule(follow zkEVM's naming). AfterRegUIntbeing renamed, the originalUIntconflicts with it so renaming the originalUInttoUIntLimbs.cc @hero78119 and @kunxian-xia