logup multiplicity in witness assignment #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
force-pushed
the
feat/lk_witness
branch
from
819edf3 to
96d357e
Compare
hero78119
force-pushed
the
feat/lk_witness
branch
3 times, most recently
from
94527e6 to
1c777b5
Compare
hero78119
force-pushed
the
feat/lk_witness
branch
from
1c777b5 to
ca0a364
Compare
hero78119
commented
Sep 9, 2024
| @@ -1,5 +1,6 @@ | |||
| #![feature(box_patterns)] | |||
| #![feature(stmt_expr_attributes)] | |||
| #![feature(variant_count)] | |||
There was a problem hiding this comment.
this is for mem::variant_count::()] to count entries of ROMType
|
Can we make it to support byte logical operations besides range check? |
Yes it can, and I just push a new commit as a demo The scope of lk_multiplicitty is just keep |
hero78119
force-pushed
the
feat/lk_witness
branch
from
d02ba40 to
7ddc98e
Compare
Merged
chaosma
reviewed
Sep 10, 2024
hero78119
force-pushed
the
feat/lk_witness
branch
from
e422cc2 to
56ea314
Compare
kunxian-xia
reviewed
Sep 10, 2024
kunxian-xia
approved these changes
Sep 10, 2024
kunxian-xia
pushed a commit
that referenced
this pull request
Sep 10, 2024
To address comment #198 (comment) For further reduce the Arc clone overhead. I think in the future we might redesign `assign_instances` to support streaming assign in the future, such that StepRecord will emit as streaming from emulator and multi-threads as worker to collect batch data and do assignment. We can explore further usage when tuning performance
hero78119
added a commit
that referenced
this pull request
Sep 30, 2024
a lock-free, thread-safe structure to count lookup multiplicicity for opcode witness assignment The lock-free, thread-safe structure is to support streaming witness assignment from emulator. Emulator emit a steptrace and insert to channel, while multi-thread are fetch step from channel and do the instance assighment concurrently while still updating the same logup multiplicity in some shared matters
hero78119
added a commit
that referenced
this pull request
Sep 30, 2024
To address comment #198 (comment) For further reduce the Arc clone overhead. I think in the future we might redesign `assign_instances` to support streaming assign in the future, such that StepRecord will emit as streaming from emulator and multi-threads as worker to collect batch data and do assignment. We can explore further usage when tuning performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lock-free, thread-safe structure to count lookup multiplicicity for opcode witness assignment
The lock-free, thread-safe structure is to support streaming witness assignment from emulator. Emulator emit a steptrace and insert to channel, while multi-thread are fetch step from channel and do the instance assighment concurrently while still updating the same logup multiplicity in some shared matters