-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify signed bit extraction via gadget #482
Comments
hero78119
changed the title
Unify signed bit extraction via
Unify signed bit extraction via gadget
Oct 28, 2024
matthiasgoergens
added a commit
that referenced
this issue
Nov 1, 2024
matthiasgoergens
added a commit
that referenced
this issue
Nov 1, 2024
…ction' into feat/#482-unify-signed-bit-extraction
KimiWu123
added a commit
that referenced
this issue
Nov 1, 2024
KimiWu123
added a commit
that referenced
this issue
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have signed bit extraction implementation in various place, especially in some gadget
E.g.
InnerSignedLtConfig
ceno/ceno_zkvm/src/gadgets/is_lt.rs
Lines 337 to 350 in e3ce193
msb_decompose
ceno/ceno_zkvm/src/uint/arithmetic.rs
Line 298 in e3ce193
By switch to
SignedExtendConfig
introduced in this PR #455 we can save wit from 2 -> 1 with same lookup cost (1 bit + 1 limb check)The text was updated successfully, but these errors were encountered: