Merge branch 'master' into matthias/remove-broken-non_pow2_rayon_thread

transcript/src/basic.rs

@@ -32,7 +32,13 @@ impl<E: ExtensionField> Transcript<E> for BasicTranscript<E> {
     }
 
     fn read_challenge(&mut self) -> Challenge<E> {
-        let r = E::from_bases(self.permutation.squeeze());
+        // notice `from_bases` and `from_limbs` has the same behavior but
+        // `from_bases` has a sanity check for length of input slices
+        // while `from_limbs` use the first two fields silently
+        // we select `from_base` here to make it being more clear that
+        // we only use the first 2 fields here to construct the
+        // extension field (i.e. the challenge)
+        let r = E::from_bases(&self.permutation.squeeze()[..2]);
 
         Challenge { elements: r }
     }