chores: more comments

scroll-tech · Oct 3, 2024 · 73e0a27 · 73e0a27
1 parent feef39f
commit 73e0a27
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/ceno_zkvm/src/uint.rs b/ceno_zkvm/src/uint.rs
@@ -234,9 +234,9 @@ impl<const M: usize, const C: usize, E: ExtensionField> UIntLimbs<M, C, E> {
                     .unwrap_or_default(),
             "assign input length mismatch",
         );
-        if let Some(carries_auxiliray_lt_config) = &self.carries_auxiliary_lt_config {
+        if let Some(carries_auxiliary_lt_config) = &self.carries_auxiliary_lt_config {
             // constrain carry range
-            for (lt_config, carry) in carries_auxiliray_lt_config.iter().zip_eq(carry_values) {
+            for (lt_config, carry) in carries_auxiliary_lt_config.iter().zip_eq(carry_values) {
                 lt_config.assign_instance(instance, lkm, Into::<u64>::into(*carry), max_carry)?;
             }
         }

diff --git a/ceno_zkvm/src/uint/util.rs b/ceno_zkvm/src/uint/util.rs
@@ -54,7 +54,10 @@ mod tests {
 
     #[test]
     fn test_max_combinations_degree() {
+        // degree=1 is pure add, therefore only one term
         assert_eq!(1, max_combinations(1, 4));
+        // for degree=2 mul, we have u[0]*v[3], u[1]*v[2], u[2]*v[1], u[3]*v[0]
+        // thus 4 terms
         assert_eq!(4, max_combinations(2, 4));
     }