Remove the cache from the provider. #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I imagine this was necessary before your item building refactoring, where resolution happened at different stages and the same provider could be called multiple times, and it is not needed anymore. But I suspect @BurnzZ might have a better view here (or/and I might be mixing different caches in my mind). |
|
This coincides with #161 where we still kinda need the cache, albeit replaced with the new one in scrapinghub/scrapy-poet#184. |
|
Ahh I think the lines like |
|
Do we only need the scrapy-poet one then? |
|
Is this still valid? |
|
Done in #161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the cache added in #94. It's possible that there are use cases that I don't see (and which aren't covered by tests) where it's used, but it looks like we shouldn't call the provider multiple times for the same request?