-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Splash responses #45
Conversation
Current coverage is
|
``/execute`` endpoint and a compatible Lua rendering script. | ||
|
||
If you want to start from the same set of cookies, but then 'fork' sessions | ||
set ``request.meta['splash']['args']['new_session_id']`` in addition to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both session_id
and new_session_id
are currently (https://github.com/scrapy-plugins/scrapy-splash/pull/45/files#diff-93e5c0fca1f417cfa28d48c75408be45R59) searched for in request.meta['splash']
, not in ```request.meta['splash']['args']`. Which is more correct, the docs or the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good catch; the code is correct. args
are arguments sent to Splash; new_session_id
is a SplashMiddleware option.
This PR provides an easier API to process data returned by Splash.
TODO:
add shortcuts to access base64-encoded values (e.g. 'png' / 'jpeg' keys);__repr__
is lost; see Disk queues don't preserve Request class scrapy/scrapy#1890.See #44, #14, #12, #10, #8.